* Clean up everything from the winrt::event debacle. * This _works_ to use a winrt event, but it's dirty * Fix a bit of dead code and a bad copy-pasta * Match the pane border to the TabViewHeader If the border is `Transparent`, then it can't hittest for Tapped events, and it'll fall through (to someone) * Encapsulate Tab::pfnFocusChanged, and clean up TerminalPage a bit * When the border is clicked on, focus that pane's controlĪnd like a lot of cleanup, because this is horrifying * when a tab GetsFocus, send the focus instead to the Pane If I want to double up and also fix #522 (which I do), then I need to also * this is janky but is close for some reason? Tested manually opening panes, closing panes, clicking around panes, the whole dance. This required us to set the color of the un-focused Pane border to some color other that Transparent, so I went with the TabViewBackground. It also contains a related fix to prevent the tab separator from stealing focus from the TermControl. Panes still track this state, for them to be able to MoveFocus appropriately. The Tab is now the arbiter of who in the tree is "active". This fixes these issue by having each Tab manually track which Pane is active in that tab. Furthermore, in experimental branches with more UI added to the Terminal (such as ( )), when these UIs were added to the Terminal, they'd take focus, which again meant that there was no focused pane. This happened especially frequently if the user clicked on a tab to focus the window. This was fraught with gotchas - if anything else became focused, then suddenly there was _no_ pane focused in the Tab. Previously, we were exclusively using the "Focused" state of `TermControl`s to determine which one was active. Afterwards, for you to close all Finder windows except one, you'd need to use one of the two AppleScripts I linked earlier. All of them will open as long as they are all from the same Finder window. Unties the concept of "focused control" from "active control". Do you mean you want to open multiple folders while in Icon View If so, select the folders you want and hit +.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |